Re: Should pg_export_snapshot() and currtid() be tagged parallel-unsafe?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andreas Seltenreich <seltenreich(at)gmx(dot)de>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Should pg_export_snapshot() and currtid() be tagged parallel-unsafe?
Date: 2016-06-15 15:45:34
Message-ID: CA+Tgmob0jYwkagx110W-433BsMKN5Z9wuGwqsr1Hbycee5hPow@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 14, 2016 at 5:01 PM, Andreas Seltenreich <seltenreich(at)gmx(dot)de> wrote:
> Digging through the sqlsmith logging db, I noticed the following errors:
>
> ERROR: cannot update SecondarySnapshot during a parallel operation
> ERROR: cannot assign XIDs during a parallel operation
>
> Queries raising the first one always contain calls to currtid() or
> currtid2(). Queries raising the second one always contain a call to
> pg_export_snapshot(). Patch to tag them as unsafe attached.

Thanks, committed.

None of these are exercised by 'make check', or this would have been
caught sooner.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-06-15 15:46:54 Re: [HACKERS] Re: pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Previous Message Noah Misch 2016-06-15 15:08:54 Re: Should phraseto_tsquery('simple', 'blue blue') @@ to_tsvector('simple', 'blue') be true ?