| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Nicholas White <n(dot)j(dot)white(at)gmail(dot)com> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Troels Nielsen <bn(dot)troels(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls |
| Date: | 2013-07-01 11:40:10 |
| Message-ID: | CA+Tgmob=-+mXmeYE_cAWjfhdWB+GLNScwbXTZR-aC4nWKv0B+Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jun 30, 2013 at 10:07 PM, Nicholas White <n(dot)j(dot)white(at)gmail(dot)com> wrote:
> I've attached another iteration of the patch that fixes the multiple-window
> bug and adds (& uses) a function to create a Bitmapset using a custom
> allocator. I don't think there's any outstanding problems with it now.
I think the right way to do this is to temporarily set the current
memory context to winobj->winstate->partcontext while creating or
manipulating the Bitmapset and restore it afterwards. Maybe someone
will say that's a modularity violation, but surely this is worse...
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jasmine | 2013-07-01 11:42:04 | Re: Randomisation for ensuring nlogn complexity in quicksort |
| Previous Message | KONDO Mitsumasa | 2013-07-01 11:29:50 | Re: [PATCH] add --progress option to pgbench (submission 3) |