Re: explain analyze rows=%.0f

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>, Andrei Lepikhov <lepihov(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: explain analyze rows=%.0f
Date: 2025-02-24 16:20:53
Message-ID: CA+TgmoazzVHn8sFOMFAEwoqBTDxKT45D7mvkyeHgqtoD2cn58Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 21, 2025 at 10:00 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I guess we could do that, but how about just always displaying two
> decimal places? I feel like you're really worried that people will be
> confused if the row count is not an integer, but I'm not sure anyone
> else has echoed that concern, and I am doubtful that it's really a
> problem. Either people don't understand that the row count is divided
> through by nloops, in which case the decimal places might actually
> give them a clue that they've misunderstood, or they do understand
> that, in which case the decimal places are not confusing. I feel like
> we've gone to a lot of trouble to come up with complex solutions --
> what was actually committed was one of the simpler things proposed --
> but I am still not convinced that the simplest solution isn't for the
> best.

So here's a patch for that. Thoughts?

--
Robert Haas
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
0001-EXPLAIN-Always-use-two-fractional-digits-for-row-cou.patch application/octet-stream 131.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Benoit Lobréau 2025-02-24 16:21:41 Re: Fix logging for invalid recovery timeline
Previous Message Melanie Plageman 2025-02-24 16:18:01 Re: BitmapHeapScan streaming read user and prelim refactoring