| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> |
| Cc: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, PgHacker <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [v9.2] DROP statement reworks |
| Date: | 2011-10-20 03:33:47 |
| Message-ID: | CA+TgmoazOGKOHaE4WSUWG-aEUwsrCJAPy7J9ZV4iRsy=ohXyrA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 19, 2011 at 3:30 PM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
> part-1: only regression test of DROP [IF EXISTS] on unmodified master
Committed. Which I just noticed broke the build farm. Will go fix that now...
> part-2: drop statement reworks that uses T_DropStmt
Committed with some changes.
> part-3: drop statement reworks for other object classes
This is going to need some rebasing.
> Unfortunately, the part-3 had to change regression test portion a bit,
> because ...
> - Unmodified master does not print ", skipping" when we tried to
> drop non-existence operator class with IF EXISTS.
OK, we should fix that.
> - Unmodified master raised an error, not notice, when we tried to
> drop non-existence operator family with IF EXISTS.
> Is it a bug to be fixed, isn't it?
Yeah, that seems like a bug.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-10-20 04:57:50 | Re: [v9.2] DROP statement reworks |
| Previous Message | Dan Ports | 2011-10-20 03:07:03 | Re: Update on documentation builds on OSX w/ macports |