| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
| Cc: | "David E(dot) Wheeler" <david(at)kineticode(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: removing =>(text, text) in 9.2 |
| Date: | 2011-11-04 14:28:23 |
| Message-ID: | CA+TgmoazD6UaO2w=SmoNqA+oxQnfRh44Sa-4hQTp=Nw8R1uPkQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 3, 2011 at 10:18 AM, Dimitri Fontaine
<dimitri(at)2ndquadrant(dot)fr> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Hmm, I was kind of expecting that to be wrong at least in some minor way.
>
>> +/* contrib/hstore/hstore-1.0-1.1.sql */
>> +
>> +-- complain if script is sourced in psql, rather than via CREATE EXTENSION
>> +\echo Use "ALTER EXTENSION hstore" to load this file. \quit
>
> You could mention ALTER EXTENSION hstore UPDATE TO 1.1; in this comment,
> I think.
>
>> +++ b/contrib/hstore/hstore--1.1.sql
>> @@ -0,0 +1,524 @@
>> +/* contrib/hstore/hstore--1.0.sql */
>
> That needs a comment update too.
Thanks for the review. New version attached.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| hstore-drop-arrow-v3.patch | application/octet-stream | 15.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2011-11-04 14:29:36 | Re: Show sequences owned by |
| Previous Message | Yoann Moreau | 2011-11-04 14:26:01 | Re: Term positions in GIN fulltext index |