Re: pgbench throttling latency limit

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Rukh Meski <rukh(dot)meski(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench throttling latency limit
Date: 2014-09-15 01:20:54
Message-ID: CA+Tgmoaz0PipgRh-GmvKevJD_K62yuTs9Gw4TGBjHTaD0Jkkgw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Sep 13, 2014 at 4:25 AM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>> [about logging...]
>
> Here is an attempt at updating the log features, including the aggregate and
> sampling stuff, with skipped transactions under throttling.
>
> I moved the logging stuff into a function which is called when a transaction
> is skipped or finished.
>
> From a log file format perspective, I think that "-" would be better than
> "skipped".

I like skipped. That seems a lot more clear, and less likely to get
parsed as a numeric value by a careless regex like [+-]\d*

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2014-09-15 03:52:36 Obsolete comment within execTuples.c
Previous Message Emanuel Calvo 2014-09-15 01:08:31 Re: BRIN indexes (was Re: Minmax indexes)