Re: a modest improvement to get_object_address()

On Wed, Nov 9, 2011 at 9:54 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> I'd like to propose the attached patch, which changes
>> get_object_address() in a manner similar to what we did in
>> RangeVarGetRelid() in commit 4240e429d0c2d889d0cda23c618f94e12c13ade7.
>
> I would think you need to drop the now-useless lock, and I sure hope
> that RangeVarGetRelid does likewise.

It doesn't currently. The now-useless lock doesn't really hurt
anything, aside from taking up space in the lock table. But we can
certainly make it (and this) do that, if you think it's worth the
extra lines of code.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company