| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, sveinn(dot)sveinsson(at)gmail(dot)com, Postgres-Bugs <pgsql-bugs(at)postgresql(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Re: BUG #14657: Server process segmentation fault in v10, May 10th dev snapshot |
| Date: | 2017-05-19 19:28:22 |
| Message-ID: | CA+TgmoaxX5CqtSSyLY0cHcUn=TLrYm4O_TzYigwY=bH26SMMRw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Fri, May 19, 2017 at 6:07 AM, Ashutosh Bapat
<ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> We still have the same copy shared across multiple append paths and
> set_plan_refs would change change it underneath those. May not be a
> problem right now but may be a problem in the future.
I agree. I think it's better for the path-creation functions to copy
the list, so that there is no surprising sharing of substructure.
set_plan_refs() obviously expects this data to be unshared, and this
seems like the best way to ensure that's true in all cases.
Committed that way.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | marko | 2017-05-22 13:20:17 | BUG #14664: Nonsensical join selectivity estimation despite n_distinct |
| Previous Message | Tom Lane | 2017-05-19 17:44:28 | Re: BUG #14662: 'has_table_privilege()' function fails with error, "invalid name syntax" when using Japanese symbols |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-05-19 19:39:44 | Re: [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur |
| Previous Message | Peter Eisentraut | 2017-05-19 19:17:24 | Re: Preliminary results for proposed new pgindent implementation |