Re: post-freeze damage control

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: post-freeze damage control
Date: 2024-04-22 19:19:15
Message-ID: CA+TgmoawS9SxzCRJ6zVZw6BE7i7RdBV6pZqgAD52ow93zccJFA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 16, 2024 at 7:20 PM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
> We maintain the invariant:
>
> XLogCtl->logFlushResult <= XLogCtl->logWriteResult
>
> and the non-shared version:
>
> LogwrtResult.Flush <= LogwrtResult.Write
>
> and that the requests don't fall behind the results:

I had missed the fact that this commit added a bunch of read and write
barriers; and I think that's the main reason why I was concerned. The
existence of those barriers, and the invariants they are intended to
maintain, makes me feel better about it.

Thanks for writing back about this!

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2024-04-22 19:22:18 Why does pgindent's README say to download typedefs.list from the buildfarm?
Previous Message David G. Johnston 2024-04-22 19:19:11 doc: create table improvements