relocating the server's backup manifest code

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: relocating the server's backup manifest code
Date: 2020-04-18 12:37:58
Message-ID: CA+TgmoavRak5OdP76P8eJExDYhPEKWjMb0sxW7dF01dWFgE=uA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

The backup manifest patch added a bunch of new code to
src/backend/replication/basebackup.c, and while lamenting the
complexity of that source file yesterday, I suddenly realized that I'd
unwittingly contributed to making that problem worse, and that it
would be quite easy to move the code added by that patch into a
separate file. Attached is a patch to do that.

Despite the fact that we are after feature freeze, I think it would be
a good idea to commit this to PG 13. It could be saved for PG 14, but
that will make future back-patching substantially harder. Also, a
patch that's just moving code is pretty low-risk.

Thoughts?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
v1-0001-Move-the-server-s-backup-manifest-code-to-a-separ.patch application/octet-stream 28.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2020-04-18 12:42:32 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Previous Message Robert Haas 2020-04-18 12:34:26 Re: snapshot too old issues, first around wraparound and then more.