Re: Misplacement of function declaration in contrib/postgres_fdw/postgres_fdw.h

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Misplacement of function declaration in contrib/postgres_fdw/postgres_fdw.h
Date: 2017-06-22 16:50:28
Message-ID: CA+Tgmoav=q06Yv0Y-Djbzz+uyWYfWSCAMWGRVT-kwqPb_=1TqQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 11, 2017 at 10:19 PM, Etsuro Fujita
<fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> While working on pushing down more joins/updates to the remote, I noticed
> that in contrib/postgres_fdw/postgres_fdw.h the declaration of
> get_jointype_name is misplaced in the section of shippable.c. Since that
> function is defined in contrib/postgres_fdw/deparse.c, we should put that
> declaration in the section of deparse.c in the header file. Attached is a
> patch for that.

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-06-22 16:50:48 Re: lseek/read/write overhead becomes visible at scale ..
Previous Message Kang Yuzhe 2017-06-22 16:46:08 Re: SQL MERGE patches for PostgreSQL Versions