Re: WAL consistency check facility

On Sat, Nov 12, 2016 at 10:06 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 11/9/16 11:55 PM, Michael Paquier wrote:
>> + <varlistentry id="guc-wal-consistency" xreflabel="wal_consistency">
>> + <term><varname>wal_consistency</varname> (<type>string</type>)
>> + <indexterm>
>> + <primary><varname>wal_consistency</> configuration parameter</primary>
>> + </indexterm>
>> + </term>
>> + <listitem>
>> + <para>
>> + This parameter is used to check the consistency of WAL records, i.e,
>> + whether the WAL records are inserted and applied correctly. When
>> + <varname>wal_consistency</varname> is enabled for a WAL record, it
>> + stores a full-page image along with the record. When a full-page image
>> + arrives during redo, it compares against the current page to check whether
>> + both are consistent.
>> + </para>
>
> Could we name this something like wal_consistency_checking?
>
> Otherwise it sounds like you use this to select the amount of
> consistency in the WAL (similar to, say, wal_level).

+1. I like that name.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company