Re: pgsql: Foreign keys on partitioned tables

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Foreign keys on partitioned tables
Date: 2018-04-06 22:46:34
Message-ID: CA+Tgmoati_yhXi8QR94dSysVJ8ShaMZ6ydD6Raez56sMkKt4PQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Apr 6, 2018 at 4:49 PM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Robert Haas wrote:
>> On Wed, Apr 4, 2018 at 1:03 PM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>> > Foreign keys on partitioned tables
>> >
>> > Author: Álvaro Herrera
>> > Discussion: https://postgr.es/m/20171231194359.cvojcour423ulha4@alvherre.pgsql
>> > Reviewed-by: Peter Eisentraut
>>
>> The commit message here was so brief that I had to read the
>> documentation to figure out exactly what this feature was.
>
> I wrote three draft commit messages, and they all seemed to be saying
> something so obvious (just repeating the commit title) that I decided
> not to repeat myself. Evidently that was a mistake.

Mainly I couldn't tell which direction(s) had been permitted without
looking within.

Not a huge deal, just mentioning it.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-04-06 22:58:44 pgsql: Remove some unnecessary quote marks from catalog DATA lines.
Previous Message Alvaro Herrera 2018-04-06 20:49:31 Re: pgsql: Foreign keys on partitioned tables

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-04-06 22:49:21 Re: src/backend/partitioning
Previous Message David Rowley 2018-04-06 22:45:21 Re: [HACKERS] Runtime Partition Pruning