Re: pg_combinebackup fails on file named INCREMENTAL.*

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Subject: Re: pg_combinebackup fails on file named INCREMENTAL.*
Date: 2024-04-18 15:10:08
Message-ID: CA+TgmoatXYc+kdPVKb0o8e+iqgyuXx281JdFvYbBqY4QbODZ=A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 17, 2024 at 7:56 PM David Steele <david(at)pgmasters(dot)net> wrote:
> Thanks! I've tested this and it works as advertised.
>
> Ideally I'd want an error on backup if there is a similar file in any
> data directories that would cause an error on combine, but I admit that
> it is vanishingly rare for users to put files anywhere but the root of
> PGDATA, so this approach seems OK to me.

OK, committed. Thanks for the review.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2024-04-18 15:17:17 Re: Transparent column encryption
Previous Message Justin Pryzby 2024-04-18 15:07:34 Re: pg17 issues with not-null contraints