| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Check existency of table/schema for -t/-n option (pg_dump/pg_res |
| Date: | 2015-09-14 14:19:42 |
| Message-ID: | CA+Tgmoary_Yjj3PiVZ1PPrvL0uQ-Yt6dY8ityGkC_kSoKrn3GA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Sep 14, 2015 at 9:20 AM, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
> Check existency of table/schema for -t/-n option (pg_dump/pg_restore)
>
> Patch provides command line option --strict-names which requires that at
> least one table/schema should present for each -t/-n option.
>
> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
/*
- * We use UNION ALL rather than UNION; this might sometimes result in
- * duplicate entries in the OID list, but we don't care.
+ * this might sometimes result in duplicate entries in the OID list,
+ * but we don't care.
*/
This looks totally incoherent. You've removed the thing to which the
word "this" referred and replaced it with nothing.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2015-09-14 14:54:14 | Re: Re: [COMMITTERS] pgsql: Check existency of table/schema for -t/-n option (pg_dump/pg_res |
| Previous Message | Tom Lane | 2015-09-14 13:56:47 | Re: [COMMITTERS] pgsql: Fix an O(N^2) problem in foreign key references. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2015-09-14 14:54:14 | Re: Re: [COMMITTERS] pgsql: Check existency of table/schema for -t/-n option (pg_dump/pg_res |
| Previous Message | Charles Clavadetscher | 2015-09-14 13:59:05 | Attach comments to functions' parameters and return value |