| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Abhijit Menon-Sen <ams(at)toroid(dot)org> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2022-02-15 16:26:29 |
| Message-ID: | CA+TgmoaqvdT-u3nt+_kkZ7bgDAyqDB0i-+XOMmr5JN2Rd37hxw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 9, 2022 at 8:41 AM Abhijit Menon-Sen <ams(at)toroid(dot)org> wrote:
> It took me a while to assimilate these patches, including the backup
> targets one, which I hadn't looked at before. Now that I've wrapped my
> head around how to put the pieces together, I really like the idea. As
> you say, writing non-trivial integrations in C will take some effort,
> but it seems worthwhile. It's also nice that one can continue to use
> pg_basebackup to trigger the backups and see progress information.
Cool. Thanks for having a look.
> Yes, it looks simple to follow the example set by basebackup_to_shell to
> write a custom target. The complexity will be in whatever we need to do
> to store/forward the backup data, rather than in obtaining the data in
> the first place, which is exactly as it should be.
Yeah, that's what made me really happy with how this came out.
Here's v2, rebased and with documentation added.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Allow-extensions-to-add-new-backup-targets.patch | application/octet-stream | 16.6 KB |
| v2-0002-Add-basebackup_to_shell-contrib-module.patch | application/octet-stream | 17.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-02-15 16:28:09 | Re: Fix overflow in DecodeInterval |
| Previous Message | Andres Freund | 2022-02-15 16:26:02 | Re: Design of pg_stat_subscription_workers vs pgstats |