Re: Remove vacuum_defer_cleanup_age

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove vacuum_defer_cleanup_age
Date: 2016-10-19 12:33:20
Message-ID: CA+Tgmoao+jpEBsGW+t7Wc4o_652URw1iHVPRc9HAmpdG3g0VGg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 18, 2016 at 4:33 PM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> Based on that argument, we would never be able to remove any
> configuration parameter ever.

Well... no. Based on that argument, we should only remove
configuration parameters if we're fairly certain that they are not
useful any more, which will be rare, but is not never. I agree that
*if* vacuum_defer_cleanup_age is no longer useful, it should be
removed. I'm just not convinced that it's truly obsolete, and you
haven't really offered much of an argument for that proposition. It
does something sufficiently different from hot_standby_feedback that
I'm not sure it's accurate to say that one can substitute for the
other, and indeed, I see Andres has already suggested some scenarios
where it could still be useful.

Actually, I think vacuum_defer_cleanup_age is, and always has been, an
ugly hack. But for some people it may be the ugly hack that is
letting them continue to use PostgreSQL.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2016-10-19 12:35:16 Re: Draft for next update release (scheduled for 27th Oct)
Previous Message Michael Paquier 2016-10-19 12:12:09 Re: FSM corruption leading to errors