Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Phil Sorber <phil(at)omniti(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c
Date: 2011-10-14 18:16:40
Message-ID: CA+TgmoanAmR+6zbVL6r=Dz=_TGpSTWndiWTOc2fJ23GWn+O+QQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 12, 2011 at 7:07 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Phil Sorber <phil(at)omniti(dot)com> writes:
>> Then there is a separate section of code that is called as a separate
>> function 'dumpUserConfig()' that does other role attributes like
>> 'ALTER ROLE bob SET role TO charlie'. These are the ALTER's that can
>> have dependencies on other roles.
>
> Right.  Phrased that way, this is an obvious improvement, and I concur
> that it doesn't look like it could break anything that works now.
> The more general problem remains to be solved, but we might as well
> apply this.

OK, done.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2011-10-14 18:36:32 Re: Large C files
Previous Message Josh Berkus 2011-10-14 18:00:30 Re: Call stacks and RAISE INFO