From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: A typo in syncrep.c |
Date: | 2015-12-18 17:44:34 |
Message-ID: | CA+Tgmoakj-Mjmz03bdC69DJvf-DpxrzUVOOVCqOD_pQJ=5RTuw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Dec 16, 2015 at 3:33 AM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Hello, I think I found a typo in a comment of syncrep.c.
>
>> * acknowledge the commit nor raise ERROR or FATAL. The latter would
>> - * lead the client to believe that that the transaction aborted, which
>> * is not true: it's already committed locally. The former is no good
>
> The 'that' looks duplicate.
Agreed.
> And it might be better to put a
> be-verb before the 'aborted'.
>
>> + * lead the client to believe that the transaction is aborted, which
No, that's correct the way it is. What you're proposing wouldn't
exactly be wrong, but it's a little less clear and direct.
Committed the part of your patch that removes the extra "that".
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2015-12-18 17:50:45 | Re: Patch: ResourceOwner optimization for tables with many partitions |
Previous Message | Tom Lane | 2015-12-18 17:44:09 | Re: Remove array_nulls? |