| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use XLOG_CONTROL_FILE macro everywhere? |
| Date: | 2024-04-26 13:06:59 |
| Message-ID: | CA+TgmoaivCgqRCD+XKAVid=+W+zz1-GNN1SQFz2Bubtfn7vEMw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 24, 2024 at 8:04 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Apr 24, 2024 at 12:32:46PM +0300, Anton A. Melnikov wrote:
> > To ensure backward compatibility we can save the old macro like this:
> >
> > #define XLOG_CONTROL_FILE "global/pg_control"
> > #define PG_CONTROL_FILE XLOG_CONTROL_FILE
> >
> > With the best wishes,
>
> Not sure that I would bother with a second one. But, well, why not if
> people want to rename it, as long as you keep compatibility.
I vote for just standardizing on XLOG_CONTROL_FILE. That name seems
sufficiently intuitive to me, and I'd rather have one identifier for
this than two. It's simpler that way.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2024-04-26 13:08:19 | Re: New committers: Melanie Plageman, Richard Guo |
| Previous Message | Nazir Bilal Yavuz | 2024-04-26 13:04:57 | Re: New committers: Melanie Plageman, Richard Guo |