Re: pg_resetxlog sentences

On Tue, Sep 15, 2015 at 9:52 PM, Euler Taveira <euler(at)timbira(dot)com(dot)br> wrote:
> While updating translations, I came across those almost similar sentences.
>
> pg_controldata.c
>
> 273 printf(_("Latest checkpoint's oldestCommitTs: %u\n"),
> 274 ControlFile.checkPointCopy.oldestCommitTs);
>
> pg_resetxlog.c
>
> 668 printf(_("Latest checkpoint's oldest CommitTs: %u\n"),
> 669 ControlFile.checkPointCopy.oldestCommitTs);
> 670 printf(_("Latest checkpoint's newest CommitTs: %u\n"),
> 671 ControlFile.checkPointCopy.newestCommitTs);
>
> To be consistent, let's change pg_resetxlog to mimic pg_controldata
> sentence. Patch is attached. It is new in 9.5 so backpatch is needed.

Seems like a good idea to me. Anyone disagree?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company