From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: why does enum_endpoint call GetTransactionSnapshot()? |
Date: | 2015-04-29 19:50:07 |
Message-ID: | CA+TgmoaiFdrcenjWqAjtvrvSPWVAymoYUCmriaHJD1Xb7htqQg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Apr 28, 2015 at 9:28 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Sat, Feb 14, 2015 at 05:29:43PM -0500, Robert Haas wrote:
>> On Sat, Feb 14, 2015 at 5:12 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> >> I think this is probably a holdover from before the death of
>> >> SnapshotNow, and that we should just pass NULL to
>> >> systable_beginscan_ordered() here, the same as we do for other catalog
>> >> accesses. Barring objections, I'll go make that change.
>> >
>> > Seems reasonable to me, but why are you only looking at that one and
>> > not the identical code in enum_range_internal()?
>>
>> I noticed that one after hitting send. I think we should change them both.
>
> Any news on this?
Done.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2015-04-29 20:03:41 | Re: Replication identifiers, take 4 |
Previous Message | Bruce Momjian | 2015-04-29 19:48:04 | Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property? |