| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoid mix char with bool type in comparisons |
| Date: | 2022-10-07 16:32:39 |
| Message-ID: | CA+TgmoahJ=qpauaktUzSBR=9+V-Wh=K=d+RNL_hF4ujj9=evEg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 7, 2022 at 11:40 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> FWIW, I did take a look at this code, and I don't see any bug.
> The entryRes[] array entries are indeed GinTernaryValue, but it's
> obvious by inspection that matchPartialInPendingList only returns
> true or false, therefore collectMatchesForHeapRow also only deals
> in true or false, never maybe. I do not think changing
> matchPartialInPendingList to return ternary would be an improvement,
> because then it'd be less obvious that it doesn't deal in maybe.
I mean if the code isn't buggy, I'm glad, but I think there should
have been more substantial grounds for getting you to spend time
looking at it. It's not asking too much for people to produce a
non-zero amount of evidence that the thing they are worried about is
actually a problem.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-10-07 16:43:31 | Re: Simplify event trigger support checking functions |
| Previous Message | Tom Lane | 2022-10-07 15:40:02 | Re: Avoid mix char with bool type in comparisons |