From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: git push hook to check for outdated timestamps |
Date: | 2015-06-24 14:03:50 |
Message-ID: | CA+TgmoagcJOSs7YXHrS1Kaw3BTCG2TFhkhP305SGM7RPRKFh-w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jun 23, 2015 at 10:15 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
>> That brings it back to the enforcing - would we want to enforce both those?
>
> May as well. AuthorDate is the main source of trouble. You would need to go
> out of your way (e.g. git filter-branch) to push an old CommitDate, but let's
> check it just the same.
Actually, you just need the system clock to be off. I've noticed, for
example, that when my VMware VMs go to sleep (because I close my
laptop lid) their clocks don't run, so I have to remember to ntpdate
afterwards if I want correct time. I don't happen to use those for
committing to PostgreSQL, but somebody else might have a similar setup
that they do use for that purpose.
So +1 for sanity-checking the commit date, and +1 as well as Alvaro's
proposal for checking for both past and future times. I think we
should tolerate a bit more in terms of past timestamps than future
timestamps. It's quite reasonable for someone to commit locally and
then run make check-world or so before pushing; let's not make that
unnecessarily annoying. But future timestamps should really only ever
happen because of clock slew, and I don't think we need to tolerate
very much of that.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2015-06-24 14:05:45 | UPSERT on partition |
Previous Message | Robert Haas | 2015-06-24 13:57:33 | Re: Multixid hindsight design |