| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: tuplesort memory usage: grow_memtuples |
| Date: | 2012-11-16 14:12:21 |
| Message-ID: | CA+TgmoagNU24igYdAG2LVgTufZMyRkwshaK2zWDzLa=dL8GQfw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 15, 2012 at 4:13 PM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
> On 15 November 2012 19:54, Greg Stark <stark(at)mit(dot)edu> wrote:
>> The only concern I had was about the behaviour after it did the
>> special case. I didn't want it to keep doing the math and trying to
>> grow again a little bit every tuple. I think I was leaning to putting
>> the magic flag back.
>
> The alternative might just be to add a new constant to the
> TupSortStatus enum. That might be more logical.
That seems like a misfit to me, but throwing in "bool
cangrowmemtuples" or something like that seems like a good solution.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2012-11-16 14:14:32 | Re: logical changeset generation v3 - comparison to Postgres-R change set format |
| Previous Message | Robert Haas | 2012-11-16 14:11:07 | Re: tuplesort memory usage: grow_memtuples |