| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
| Date: | 2022-03-31 18:12:20 |
| Message-ID: | CA+TgmoagL-3hC0PvE++VFW5y9y+c+XHtVVuUUkwC-HZsDRzCJA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Mar 31, 2022 at 12:56 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I agree. That's exactly what I said in
> http://postgr.es/m/CA+TgmoasOhqLR=TSYmHd4TyX-qnfwtde_u19ZphKunpSCkh_iw@mail.gmail.com
> ...
OK, so I pushed a commit adding that incantation to the test script,
and also a comment explaining why it's there. Possibly we ought to go
add similar comments to other places where this incantation is used,
or find a way to make this all a bit more self-documenting, but that
doesn't necessarily need to be done today.
The buildfarm does look rather green at the moment, though, so I'm not
sure how I know whether this "worked".
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2022-03-31 18:17:26 | pgsql: Remove use of perl parent module in Cluster.pm |
| Previous Message | Robert Haas | 2022-03-31 18:06:29 | pgsql: In basebackup_to_shell tests, properly set up pg_hba.conf. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2022-03-31 18:15:25 | Re: [PATCH] Accept IP addresses in server certificate SANs |
| Previous Message | Daniel Gustafsson | 2022-03-31 18:10:35 | Re: support for MERGE |