| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add sub-transaction overflow status in pg_stat_activity |
| Date: | 2022-11-14 15:52:08 |
| Message-ID: | CA+TgmoafUNMM-L0af9d0gV5x_MwQ-DjB9G0eqT+i1y5NVDkbHw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 14, 2022 at 10:41 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Maybe the original patch took an hour to write, but it's sure been
> bikeshedded to death :-(. I was complaining about the total amount
> of attention spent more than the patch itself.
Unfortunately, that problem is not unique to this patch, and even more
unfortunately, despite all the bikeshedding, we still often get it
wrong. Catching up from my week off I see that you've fixed not one
but two bugs in a patch I thought I'd reviewed half to death. :-(
> The patch of record seems to be v4 from 2022-01-13, which was failing
> in cfbot at last report but presumably could be fixed easily. The
> proposed documentation's grammar is pretty shaky, but I don't see
> much else wrong in a quick eyeball scan.
I can take a crack at improving the documentation. Do you have a view
on the best way to cut this down to a single new column, or the
desirability of doing so?
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2022-11-14 15:57:39 | Re: Add sub-transaction overflow status in pg_stat_activity |
| Previous Message | Tom Lane | 2022-11-14 15:41:29 | Re: Add sub-transaction overflow status in pg_stat_activity |