| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: dropping datumSort field |
| Date: | 2022-08-09 15:01:44 |
| Message-ID: | CA+TgmoaeFBR+n7NNTjGyDiQwpFur29OCthmtEp8cj=Ph_UEnoA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 8, 2022 at 5:51 PM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> Hi,
> I was looking at ExecSort() w.r.t. datum sort.
>
> I wonder if the datumSort field can be dropped.
> Here is a patch illustrating the potential simplification.
>
> Please take a look.
One problem with this patch is that, if I apply it, PostgreSQL does not compile:
nodeSort.c:197:6: error: use of undeclared identifier 'tupDesc'
if (tupDesc->natts == 1)
^
1 error generated.
Leaving that aside, I don't really see any advantage in this sort of change.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2022-08-09 15:03:04 | Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size |
| Previous Message | Robert Haas | 2022-08-09 14:36:57 | Re: Reducing the chunk header sizes on all memory context types |