Re: [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.

On Wed, Mar 22, 2017 at 4:00 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 3/22/17 14:09, Robert Haas wrote:
>>> The opposite means primary. I can flip the GUC name to "is_primary", if
>>> that's clearer.
>> Hmm, I don't find that clearer. "hot standby" has a very specific
>> meaning; "primary" isn't vague, but I would say it's less specific.
>
> The problem I have is that there is already a GUC named "hot_standby",
> which determines whether an instance is in hot (as opposed to warm?)
> mode if it is a standby. This is proposing to add a setting named
> "in_hot_standby" which says nothing about the hotness, but something
> about the standbyness. Note that these are all in the same namespace.

Good point.

> I think we could use "in_recovery", which would be consistent with
> existing naming.

True.

(Jaime's question is also on point, I think.)

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company