Re: [PATCH] optional cleaning queries stored in pg_stat_statements

On Sun, Nov 6, 2011 at 2:56 PM, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
> Peter's patch adds a planner hook and hashes at that level.  Since this cat
> is rapidly escaping its bag and impacting other contributors, we might as
> well share the work in progress early if anyone has a burning desire to look
> at the code.  A diff against the version I've been internally reviewing in
> prep for community submission is at
> https://github.com/greg2ndQuadrant/postgres/compare/master...pg_stat_statements_norm
>  Easier to browse than ask questions probing about it I think.  Apologies to
> Peter for sharing his work before he was completely ready; there is a list
> of known problems with it.  I also regret the thread hijack here.

I think it's an established principle that the design for features
like this should, for best results, be discussed on -hackers before
writing a lot of code. That not only avoids duplication of effort
(which is nice), but also allows design decisions like "what exactly
should we hash and where should the hooks be?" to be ironed out early,
before they can force a major rewrite. Of course, there's no hard
requirement, but the archives are littered with patches that crashed
and burned because the author wrote them in isolation and then, upon
receiving feedback from the community that necessitated a full
rewrite, gave up.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company