From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: split builtins.h to quote.h |
Date: | 2014-11-07 21:35:36 |
Message-ID: | CA+Tgmoaa1amp5QXJoWyERMUgGLMzrjBu35pRp=McdiH_BJhQPA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Nov 7, 2014 at 3:55 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Michael Paquier wrote:
>> On Fri, Nov 7, 2014 at 2:31 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
>> > I thought the consensus was that the SQL-callable function declarations
>> > should remain in builtins.h -- mainly so that quote.h does not need to
>> > include fmgr.h.
>> Moving everything to quote.h is done in-line with what Tom and Robert
>> suggested, builtins.h being a refuge for function declarations that
>> have nowhere else to go. Suggestion from here:
>> http://www.postgresql.org/message-id/CA+TgmoZF3dkpTuA6Ex6gXLnnd-nMS-fBjCXRoiTwFfH-+6yBQQ@mail.gmail.com
>
> Did you miss this one?
> http://www.postgresql.org/message-id/31728.1413209460@sss.pgh.pa.us
I personally think that's getting our priorities backwards, but
there's clearly a spectrum in terms of how much people care about the
cost of partial compiles, and I'm clearly all the way on one end of
it. I don't like having to think hard about where a function
prototype is or should be, and getting more consistency there would,
for me, outweigh all other considerations.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2014-11-07 21:37:13 | Re: printing table in asciidoc with psql |
Previous Message | Robert Haas | 2014-11-07 21:30:23 | Re: recovery_target_time and standby_mode |