| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | something has gone wrong, but what is it? |
| Date: | 2022-08-10 13:41:30 |
| Message-ID: | CA+Tgmoa_AZ2jUWSA_noiqOqnxBaWDR+t3bHjSygZi6+wqDBCXQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Today while hacking I encountered this delight:
2022-08-10 09:30:29.025 EDT [27126] FATAL: something has gone wrong
I actually already knew that something had gone wrong, because the
code I was writing was incomplete. And if I hadn't known that, the
word FATAL would have been a real good clue. What I was hoping was
that the error message might tell me WHAT had gone wrong, but it
didn't.
This seems to be the fault of Andres's commit
5aa4a9d2077fa902b4041245805082fec6be0648. In his defense, the addition
of any kind of elog() at that point in the code appears to be an
improvement over the previous state of affairs. Nonetheless I feel we
could do better still, as in the attached.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Be-more-specific-about-exactly-what-has-gone-wron.patch | application/octet-stream | 819 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-08-10 13:48:08 | Re: pg_get_constraintdef: Schema qualify foreign tables unless pretty printing is enabled |
| Previous Message | osumi.takamichi@fujitsu.com | 2022-08-10 13:30:52 | RE: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |