| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Optimise default partition scanning while adding new partition |
| Date: | 2017-09-15 15:59:18 |
| Message-ID: | CA+Tgmoa_8Kjbjz4gYM1TTVv3j8RW5pSRJnHxK4Q-V8hnMRcpKw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 15, 2017 at 2:00 AM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> I wonder if we should call check_default_allows_bound() from
> ATExecAttachPartition(), too, instead of validating updated default
> partition constraint using ValidatePartitionConstraints()? That is, call
> the latter only to validate the partition constraint of the table being
> attached and call check_default_allows_bound() to validate the updated
> default partition constraint. That way, INFO/ERROR messages related to
> default partition constraint are consistent across the board.
I believe the intended advantage of the current system is that if you
specify multiple operations in a single ALTER TABLE command, you only
do one scan rather than having a second scan per operation. If that's
currently working, we probably don't want to make it stop working.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-09-15 16:01:22 | Re: Re: [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur |
| Previous Message | Robert Haas | 2017-09-15 15:42:36 | Re: [JDBC] Channel binding support for SCRAM-SHA-256 |