| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
| Subject: | Re: extensible external toast tuple support |
| Date: | 2013-06-28 13:23:27 |
| Message-ID: | CA+Tgmoa_4qCB0EdH2bz22Zetkd7hgQCeQTLai349dG4gmmEKow@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 27, 2013 at 12:56 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> Please find attached the next version of the extensible toast
> support. There basically are two changes:
>
> * handle indirect toast tuples properly in heap_tuple_fetch_attr
> and related places
> * minor comment adjustments
It looks to me like you need to pass true, rather than false, as the
first argument to TrapMacro:
+#define VARTAG_SIZE(tag) \
+ ((tag) == VARTAG_INDIRECT ? sizeof(varatt_indirect) : \
+ (tag) == VARTAG_ONDISK ? sizeof(varatt_external) : \
+ TrapMacro(false, "unknown vartag"))
Still looking at the rest of this.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2013-06-28 13:31:00 | Re: proposal: enable new error fields in plpgsql (9.4) |
| Previous Message | Noah Misch | 2013-06-28 13:20:26 | Re: proposal: enable new error fields in plpgsql (9.4) |