From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Allow external recovery_config_directory |
Date: | 2013-03-27 13:21:33 |
Message-ID: | CA+TgmoaXcRdSjsEM-CDi9=D0PSHbY8-FCTtzEOQ8c5tT7m6x_Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Wed, Mar 27, 2013 at 9:11 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On 27 March 2013 12:59, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
>
>> Also, based on Greg's spec (that Robert and I basically agreed on), if
>> recovery.conf is found at the root of data folder an error is returned to
>> user, recommending him to migrate correctly by referring to dedicated
>> documentation.
>
> I'm following what was agreed on 24 December.
I assume that you are referring to this message:
I don't see a followup from anyone clearly agreeing that this was a
useful thing to do. There is a lot of support for turning
recovery.conf parameters into GUCs. But I don't remember anyone
supporting this idea, and like Heikki and Michael, I don't understand
how it moves the ball forward.
Considering there's been no discussion of this particular change in
three months, and not a whole lot back then, I think it would have
been polite to post the patch and ask for comments before committing
it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2013-03-27 13:28:05 | Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt. |
Previous Message | Thom Brown | 2013-03-27 13:14:07 | Re: pgsql: Allow external recovery_config_directory |
From | Date | Subject | |
---|---|---|---|
Next Message | Dean Rasheed | 2013-03-27 13:21:49 | Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL) |
Previous Message | Thom Brown | 2013-03-27 13:14:07 | Re: pgsql: Allow external recovery_config_directory |