| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: "page is not marked all-visible" warning in regression tests |
| Date: | 2012-06-07 16:49:59 |
| Message-ID: | CA+TgmoaX7Tbc365WQrm2d=kJse0etRSwbAKkm=zJbDZHVtsJoQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 7, 2012 at 12:41 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Updated patch attached.
>
> The comments need a pass of copy-editing, eg here and here:
>
>> + * so somebody else could be change the bit just after we look at it. In fact,
> ^^^^^^^^^^^^^^^
>
>> + * got cleared after we checked it and before we got took the buffer
> ^^^^^^^^
>
> Seems reasonable beyond that.
Thanks, committed with those fixes and a correction for one more typo
I spotted elsewhere.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2012-06-07 16:52:23 | Re: Avoiding adjacent checkpoint records |
| Previous Message | Tom Lane | 2012-06-07 16:41:39 | Re: "page is not marked all-visible" warning in regression tests |