| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>, Alexander Lakhin <exclusion(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Date: | 2024-04-15 14:30:57 |
| Message-ID: | CA+TgmoaWVq0omunhPzwKt=L7fqUFDgJcLiodmZ_ZqBNiPxzY+Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Apr 13, 2024 at 6:05 AM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> Please, find a my version of this fix attached. I think we need to
> check relpersistence in a similar way ATTACH PARTITION or CREATE TABLE
> ... PARTITION OF do. I'm going to polish this a little bit more.
+ errmsg("\"%s\" is not an ordinary table",
This is not a phrasing that we use in any other error message. We
always just say "is not a table".
+ * Open the new partition and acquire exclusive lock on it. This will
A minor nitpick is that this should probably say access exclusive
rather than exclusive. But the bigger thing that confuses me here is
that if we just created the partition, surely we must *already* hold
AccessExclusiveLoc on it. No?
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-04-15 14:54:16 | Re: Issue with the PRNG used by Postgres |
| Previous Message | Marina Polyakova | 2024-04-15 14:20:00 | Re: cpluspluscheck/headerscheck require build in REL_16_STABLE |