From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Noah Misch <noah(at)leadboat(dot)com>, "Adam, Etienne (Nokia-TECH/Issy Les Moulineaux)" <etienne(dot)adam(at)nokia(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>, "Duquesne, Pierre (Nokia-TECH/Issy Les Moulineaux)" <pierre(dot)duquesne(at)nokia(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [BUGS] [postgresql 10 beta3] unrecognized node type: 90 |
Date: | 2017-08-15 13:20:41 |
Message-ID: | CA+TgmoaWPtfdcZjg+dqLephgKaG7kF8DEdvB870A2t4cUh5x+Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Tue, Aug 15, 2017 at 7:31 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Tue, Aug 15, 2017 at 8:22 AM, Noah Misch <noah(at)leadboat(dot)com> wrote:
>> On Fri, Aug 11, 2017 at 11:59:14AM -0400, Tom Lane wrote:
>>> "Adam, Etienne (Nokia-TECH/Issy Les Moulineaux)" <etienne(dot)adam(at)nokia(dot)com> writes:
>>> > ERROR: XX000: unrecognized node type: 90
>>> > LOCATION: ExecReScan, execAmi.c:284
>>>
>>> (gdb) p (NodeTag) 90
>>> $1 = T_GatherMergeState
>>>
>>> So, apparently somebody wrote ExecReScanGatherMerge, but never bothered
>>> to plug it into ExecReScan.
>
> Attached patch fixes the issue for me. I have locally verified that
> the gather merge gets executed in rescan path. I haven't added a test
> case for the same as having gather or gather merge on the inner side
> of join can be time-consuming. However, if you or others feel that it
> is important to have a test to cover this code path, then I can try to
> produce one.
Committed.
I believe that between this commit and the test-coverage commit from
Andres, this open item is reasonably well addressed. If someone
thinks more needs to be done, please specify. Thanks.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-08-15 13:46:09 | Re: [HACKERS] [postgresql 10 beta3] unrecognized node type: 90 |
Previous Message | Amit Kapila | 2017-08-15 11:31:44 | Re: [postgresql 10 beta3] unrecognized node type: 90 |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-08-15 13:24:28 | Re: [PATCH] pageinspect function to decode infomasks |
Previous Message | Etsuro Fujita | 2017-08-15 12:20:10 | Stats for triggers on partitioned tables not shown in EXPLAIN ANALYZE |