| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dave Cramer <pg(at)fastcrypt(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Craig Ringer <craig(at)2ndquadrant(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status) |
| Date: | 2019-07-11 14:06:23 |
| Message-ID: | CA+TgmoaWFKF1h__VP275MSBTOoOH6hrD33TtYSknG2nGORVEfg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 11, 2019 at 8:23 AM Dave Cramer <pg(at)fastcrypt(dot)com> wrote:
> See attached for an initial patch. If this is an acceptable way to go I will add tests and documentation
And clean up the code? Doesn't look crazy on a quick glance but I
think I see at least half a dozen coding style problems. More
substantively:
1. I don't really like putting 'guc' into an externally visible name;
that's why I suggested 'report'.
2. I haven't really scrutinized whether what SetConfigReport is an OK
way of implementing this. That probably needs some study. It may be
fine.
3. I'm not sure that just ignoring any GUCs we don't find is the right
thing. I'm also not sure that it's the wrong thing, but it might be.
My question is: what if there's an extension-owned GUC in play? The
library probably isn't even loaded at this stage, unless it's in
shared_preload_libraries.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thom Brown | 2019-07-11 14:09:28 | Re: SQL/JSON path issues/questions |
| Previous Message | Euler Taveira | 2019-07-11 14:05:38 | Re: base backup client as auxiliary backend process |