Re: Last gasp

On Thu, Apr 5, 2012 at 2:23 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> In fact, for *most* of these patches the fact that they're still here
> should give you pause about just committing them.

Um, yeah.

>> I am not sure what the state of the foreign stats patch is, or FK arrays.
>
> I'm taking the foreign stats one; as I mentioned a bit ago, I think we
> need to push an FDW ANALYZE hook into 9.2.  I don't like the details of
> what's in the current submission but I think it's fixable with not much
> effort.

Cool.

> The FK arrays one I'm kind of queasy about.  It's a cool-sounding idea
> but I'm not convinced that all the corner-case details have been
> adequately thought through, and I'm scared of being unable to fix any
> such bugs in later versions because of backwards compatibility worries.
> It'd be a lot better to be pushing this in at the start of a devel cycle
> than the end.

I've been feeling that that patch has been suffering from a lack of
reviewer attention, which is a real shame, because I think the
functionality is indeed really cool. But I haven't looked at it
enough to know what kind of shape it's in.

> Most of the rest of this stuff I'm about ready to put off to 9.3.
> The risk/reward ratio for committing it on the last day of the last
> 9.2 fest doesn't look good.

+1.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company