From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Rahila Syed <rahilasyed90(at)gmail(dot)com> |
Subject: | Re: Add missing PGDLLIMPORT markings |
Date: | 2025-04-10 16:03:00 |
Message-ID: | CA+TgmoaV78kUusC+P761Dwy=s9tUKAjEVWDYHWDSF-urP04VcQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Apr 9, 2025 at 1:10 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> I think eventually we ought to change the default visibility in the main binary to hidden, just like we do for extensions. Then the windows/everything else behavior difference vanishes and we actually get the benefit of being more restrictive on common platforms. I think we still ought to default to exporting symbols in such a world, just not always do so. We probably should just require all externs are either marked "server only" or "visible to extensions", never just a plain extern.
The issue we're going to run into is that a lot of extension authors
like to call things that the core developers probably think they
shouldn't. If we lock it down, we'll either be breaking a bunch of
extensions that are doing sneaky things that somebody has managed to
make work ... or we're going to be committing to an API that we don't
really want to support.
To be clear, I'm not saying you're wrong, just that it's going to be
hard to change anything without making somebody unhappy.
--
Robert Haas
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2025-04-10 16:17:54 | Re: Correct documentation for protocol version |
Previous Message | Tom Lane | 2025-04-10 16:00:32 | Re: Capturing both IP address and hostname in the log |