| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: checksum verification code breaks backups in v16- |
| Date: | 2024-12-04 14:29:50 |
| Message-ID: | CA+TgmoaV43sD=s6t7ksJ8Ti-o716r4GpVVWGLguEnTtczfFOTg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 3, 2024 at 5:26 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> On Tue, Dec 03, 2024 at 11:39:43AM -0500, Robert Haas wrote:
> > If we want a narrower and thus less-risky fix, we could consider just
> > adjusting this code here:
> >
> > segmentno = atoi(segmentpath + 1);
> > if (segmentno == 0)
> > ereport(ERROR,
> > (errmsg("invalid segment number %d in file \"%s\"",
> > segmentno, filename)));
>
> I'm only seeing this code in pg_checksums. Is that what you are proposing
> to change?
No. This code is present in src/backend/backup/basebackup.c in REL_16_STABLE.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-12-04 14:33:46 | Re: Replace current implementations in crypt() and gen_salt() to OpenSSL |
| Previous Message | Robert Haas | 2024-12-04 14:28:06 | Re: Replace current implementations in crypt() and gen_salt() to OpenSSL |