Re: Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Noah Misch <noah(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE
Date: 2011-07-07 19:06:46
Message-ID: CA+TgmoaSfN-4xoxAQEHHCX9+HXPTfpUE+S+zphkwe7J0pkx-Fw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 7, 2011 at 2:55 PM, Noah Misch <noah(at)2ndquadrant(dot)com> wrote:
> CheckIndexCompatible() calls ComputeIndexAttrs() to resolve the new operator
> classes, collations and exclusion operators for each index column.  It then
> checks those against the existing values for the same.  I figured that was
> obvious enough, but do you want a new version noting that?

I guess one question I had was... are we depending on the fact that
ComputeIndexAttrs() performs a bunch of internal sanity checks? Or
are we just expecting those to always pass, and we're going to examine
the outputs after the fact?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-07-07 19:09:31 pgsql: Adjust OLDSERXID_MAX_PAGE based on BLCKSZ.
Previous Message Kevin Grittner 2011-07-07 18:59:17 Re: SSI atomic commit