| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix search_path to a safe value during maintenance operations. |
| Date: | 2023-06-12 17:33:45 |
| Message-ID: | CA+TgmoaSJDJMqn-E5Xp=6Ojc_1C_MKnBPyctAOF1buBU=RPEiw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Jun 12, 2023 at 1:05 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> > I concur with the upthread objection that it is way too late in
> > the release cycle to be introducing a breaking change like this.
> > I request that you revert it.
>
> The timing was not great, but this is fixing a purported defect in an older
> v16 feature. If the MAINTAIN privilege is actually fine, we're all set for
> v16. If MAINTAIN does have a material problem that $SUBJECT had fixed, we
> should either revert MAINTAIN, un-revert $SUBJECT, or fix the problem a
> different way.
I wonder why this commit used pg_catalog, pg_temp rather than just the
empty string, as AutoVacWorkerMain does.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2023-06-13 00:20:47 | Re: pgsql: Fix search_path to a safe value during maintenance operations. |
| Previous Message | Noah Misch | 2023-06-12 17:05:10 | Re: pgsql: Fix search_path to a safe value during maintenance operations. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2023-06-12 17:34:58 | Re: Do we want a hashset type? |
| Previous Message | Andres Freund | 2023-06-12 17:20:38 | Re: Meson build updates |