| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Aidar Imamov <a(dot)imamov(at)postgrespro(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, koshy44(at)gmail(dot)com |
| Subject: | Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions |
| Date: | 2025-04-11 11:43:38 |
| Message-ID: | CA+TgmoaS3Jfaacg5UuPZHPfKOjwBsTyjWfhUG1DSokHH8-nqDQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 11, 2025 at 4:02 AM Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> I understand your point. I did it like that because bufferids start
> from 1 and go to NBuffers inclusive in the pg_buffercache view, so it
> seems more natural to me to implement it like that. I am okay to
> replace these loops with [1] to make it standart everywhere:
>
> [1]
> for (int buf = 0; buf < NBuffers; buf++)
> {
> BufferDesc *desc = GetBufferDescriptor(buf);
I'm more making an observation than asking for a change. If you and
others think it should be changed, that is fine, but I'm uncertain
myself what we ought to be doing here. I just wanted to raise the
issue.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2025-04-11 12:07:55 | Re: as per commit 643a1a61985bef2590496, move create/open dir code to function using switch case of pg_backup_directory.c file also |
| Previous Message | Ranier Vilela | 2025-04-11 11:27:23 | Re: Silence resource leaks alerts |