Re: Forbid referencing columns by names in ALTER INDEX ... SET STATISTICS

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Forbid referencing columns by names in ALTER INDEX ... SET STATISTICS
Date: 2018-06-28 14:26:13
Message-ID: CA+TgmoaRfm_byKQR7A1CrOs0Z9QiLZYmYHe2b8Jq909iLLMtoQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 27, 2018 at 9:22 AM, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> According to the syntax in ALTER INDEX doc, a column should be specified by
> column number as discussed in [1]. However, the current code still allows to
> use an internal column name like "expr". Is this intentional?
>
> Although it is harmless, how about forbiding this undocumented and
> unuseful behavior. The attached patch does it.

If it's harmless, why prohibit it?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-06-28 15:14:38 Re: Tips on committing
Previous Message Alexander Kuzmenkov 2018-06-28 14:23:25 Re: Generating partitioning tuple conversion maps faster