From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: ERROR: ORDER/GROUP BY expression not found in targetlist |
Date: | 2016-06-17 16:26:25 |
Message-ID: | CA+TgmoaR3-DWxQFiw_5Z3zOi=-+SzFGksVdQef+nyVKWpSCJNQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jun 17, 2016 at 9:29 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Jun 17, 2016 at 9:04 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>> Attached, please find updated patch based on above lines. Due to addition
>> of projection path on top of partial paths, some small additional cost is
>> added for parallel paths. In one of the tests in select_parallel.sql the
>> plan was getting converted to serial plan from parallel plan due to this
>> cost, so I have changed it to make it more restrictive. Before changing, I
>> have debugged the test to confirm that it was due to this new projection
>> path cost. I have added two new tests as well to cover the new code added
>> by patch.
>
> I'm going to go work on this patch now.
Here is a revised version, which I plan to commit in a few hours
before the workday expires. I kept it basically as Amit had it, but I
whacked the comments around some and, more substantively, avoided
inserting and/or charging for a Result node when that's not necessary.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
fix-scanjoin-pathtarget-v3.patch | text/x-diff | 9.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Aleksey Demakov | 2016-06-17 16:34:14 | Re: Experimental dynamic memory allocation of postgresql shared memory |
Previous Message | Aleksey Demakov | 2016-06-17 16:20:39 | Re: Experimental dynamic memory allocation of postgresql shared memory |