| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [RFC] Incremental backup v2: add backup profile to base backup |
| Date: | 2014-10-06 15:55:30 |
| Message-ID: | CA+TgmoaPXp=S5OSQKqZXZ52G0fx2Bx5qVKXnkpjdu_C+hBVodQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 6, 2014 at 11:51 AM, Marco Nenciarini
<marco(dot)nenciarini(at)2ndquadrant(dot)it> wrote:
> I agree that a full backup does not need to include a profile.
>
> I've added the option to require the profile even for a full backup, as
> it can be useful for backup softwares. We could remove the option and
> build the profile only during incremental backups, if required. However,
> I would avoid the needing to scan the whole backup to know the size of
> the recovered data directory, hence the backup profile.
That doesn't seem to be buying you much. Calling stat() on every file
in a directory tree is a pretty cheap operation.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gabriele Bartolini | 2014-10-06 16:00:40 | Re: [RFC] Incremental backup v2: add backup profile to base backup |
| Previous Message | Marco Nenciarini | 2014-10-06 15:51:11 | Re: [RFC] Incremental backup v2: add backup profile to base backup |