| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Christian Kruse <christian(at)2ndquadrant(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication |
| Date: | 2014-01-31 16:24:51 |
| Message-ID: | CA+TgmoaM0hNR8h4F8xSc5jhJC=Gp6AZ8p=xqiZQKPgNeHvXQ=A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 31, 2014 at 8:02 AM, Christian Kruse
<christian(at)2ndquadrant(dot)com> wrote:
> what do you think about the approach the attached patch implements?
> I'm not really sure if this is what you had in mind, especially if
> this is the right lock.
The attached patch seems not to be attached, but the right lock to use
would be the same one BackendIdGetProc() is using. I'd add a new
function BackendIdGetTransactionIds or something like that.
>> I also note that the docs seem to need some copy-editing:
>>
>> + <entry>The current <xref linked="ddl-system-columns">xmin
>> value.</xref></entry>
The link shouldn't include the period, and probably should also not
include the word "value". I would make only the word "xmin" part of
the link.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-01-31 16:31:40 | Re: small typo in src/backend/access/transam/xlog.c |
| Previous Message | Robert Haas | 2014-01-31 16:23:17 | Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication |