| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Issue with cancel_before_shmem_exit while searching to remove a particular registered exit callbacks |
| Date: | 2020-07-24 14:37:40 |
| Message-ID: | CA+TgmoaLiX7kwxBc1Bdm2Ljnc+cH_MZd1N7KC7GjKruQigx=2g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 24, 2020 at 7:10 AM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> I looked at what actually llvm_shutdown() does? It frees up JIT stacks, also if exists perf related resource, using LLVMOrcDisposeInstance() and LLVMOrcUnregisterPerf(), that were dynamically allocated in llvm_session_initialize through a JIT library function LLVMOrcCreateInstance() [1].
>
> It looks like there is no problem in moving llvm_shutdown to either on_shmem_exit() or on_proc_exit().
If it doesn't involve shared memory, I guess it can be on_proc_exit()
rather than on_shmem_exit().
I guess the other question is why we're doing it at all. What
resources are being allocated that wouldn't be freed up by process
exit anyway?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christophe Pettus | 2020-07-24 14:38:08 | Re: Row estimates for empty tables |
| Previous Message | Robert Haas | 2020-07-24 14:35:32 | Re: [Patch] ALTER SYSTEM READ ONLY |